nf-core / pathogensurveillance

Surveillance of pathogens using population genomics and sequencing
https://nf-co.re/pathogensurveillance
MIT License
13 stars 5 forks source link

Make sure variant calling for eukaryotes takes into account heterozyzgous variants #33

Open zachary-foster opened 1 year ago

masudermann commented 1 week ago

Just following up about this issue.

I think our current filtering approach filters out any heterozygous SNPs by default (if the bacterial SNP analysis workflow was adapted). We should double check this again and also be transparent about this.

The downstream filter steps (like vcf-to-tab step) are only consistent if this is the case.

In addition, we need to check that the intermediate SNP output tables (in vcf_to_tab directory) make sense, not just for haploid organisms.

I will have some new tables generated shortly and will follow-up with this.