nf-core / phaseimpute

MIT License
16 stars 12 forks source link

Panel chunking #95

Open LouisLeNezet opened 1 week ago

LouisLeNezet commented 1 week ago

Description of feature

Do we really need to chunks with Glimpse1 and 2. I would guess that both of them should produce the same output in the end. As Glimpse2 has more option, I would suggest to only chunks with the version 2. What do you think ?

atrigila commented 1 week ago

I agree we could do only one type of chunking.

glimpse2 chunking had some issues in the past (I think segmentation fault occurred sometimes) and also it did not work with "sequential" mode.

If we modify that in the nf-core modules, test them and make it work, I think we can add the updated module in phaseimpute and remove glimpse1.