search

nf-core / proteomicslfq

Proteomics label-free quantification (LFQ) analysis pipeline
https://nf-co.re/proteomicslfq
MIT License
33 stars 19 forks source link

Version parsing regex can't parse some valid version #164

Open fabianegli opened 3 years ago

fabianegli commented 3 years ago

https://github.com/nf-core/proteomicslfq/blob/43c77e50c955d7e62899e7d31e0d6f6a87ac2316/bin/scrape_software_versions.py#L6

The above regex r"([0-9][.][0-9][.][0-9])" doesn't match the historic openMS version 1.11.0. I think the regex should be either expanded to allow multi digit main, minor and bug release versions or maybe even be expanded to match all Semantic Versioning 2.0.0, if that is indeed what openMS (and the other tools) adheres to. The SemVer website contains regexes with and without named groups: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

fabianegli commented 3 years ago

... and the regexes got ditched for this job. See the current scrape_software_versions.py and this PR diff.

jpfeuffer commented 3 years ago

I think version parsing probably just moved to each module.