search

nf-core / quantms

Quantitative mass spectrometry workflow. Currently supports proteomics experiments with complex experimental designs for DDA-LFQ, DDA-Isobaric and DIA-LFQ quantification.
https://nf-co.re/quantms
MIT License
31 stars 0 forks source link

do not hardcode sdrf-pipelines version #58

Closed fabianegli closed 1 year ago

fabianegli commented 2 years ago

Hardcoding the version information like seen below bears the potential to be inconsistent with the actual sdrf-pipelines version

https://github.com/nf-core/quantms/blob/6ffb0c92964cb70e212e18225c769b9e26cb1c11/modules/local/samplesheet_check.nf#L26

parse_sdrf --version

Is now the way to get the version in future releases of sdrf-pipelines.

fabianegli commented 2 years ago

There are other files, too that use the hardcoded sdrf-version reporting.

jpfeuffer commented 1 year ago

Fixed in #111