Closed pinin4fjords closed 2 months ago
master
branch :x:base
to dev
Hi @pinin4fjords,
It looks like this pull-request is has been made against the nf-core/rnaseq master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the nf-core/rnaseq dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 765e67d
+| ✅ 173 tests passed |+
#| ❔ 9 tests were ignored |#
!| ❗ 7 tests had warnings |!
Addresses https://github.com/nf-core/rnaseq/issues/1377. Basically R will mangle names with symbols when constructing data frames and the like, unless you explicitly tell it not too, which I am doing here. This was neglected when we factored out and tidied up these modules in the last release.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).