Closed nschcolnicov closed 9 months ago
It feels like you have a couple of template update in your PR, can you check that up?
It feels like you have a couple of template update in your PR, can you check that up?
@maxulysse I pulled the latest changes from dev, let me know if there is anything else needed
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 99eb935
+| ✅ 163 tests passed |+
!| ❗ 4 tests had warnings |!
@maxulysse I see that the only check missing is the "prettier" one, I have run the command prettier --check in the branch and I don't see any issues:
Is there a way of knowing what is causing this failed test?
@nf-core-bot fix linting pretty please
@maxulysse I see that the only check missing is the "prettier" one, I have run the command prettier --check in the branch and I don't see any issues:
Is there a way of knowing what is causing this failed test?
It should be good now
PR checklist
CHANGE SUMMARY
Adding the possibility of using gzipped fasta and gtf files as input reference files.
I tested running this with the test_full dataset using a gzipped fasta and gtf file and it passed, I also run the test profile using the regular genome files and it passed too.
Added the unzip module using the nf-core tooling (nf-core modules install unzip)
I ran the nf-core lint command, and then nf-core lint --fix files_unchanged, there is only one issue remaining, which is unrelated to these changes:
[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Make sure your code lints (
nf-core lint
).[x] Ensure the test suite passes (
nextflow run . -profile test,docker --outdir <OUTDIR>
).[x] Usage Documentation in
docs/usage.md
is updated.[x] Output Documentation in
docs/output.md
is updated.[x]
CHANGELOG.md
is updated.[x]
README.md
is updated (including new tool citations and authors/contributors).