Closed nschcolnicov closed 8 months ago
nf-core lint
overall result: Failed :x:Posted for pipeline commit 4438535
+| ✅ 177 tests passed |+
!| ❗ 4 tests had warnings |!
-| ❌ 10 tests failed |-
Looking good, I'll merge template separately, so not to worry too much about that
This PR addresses this issue: https://github.com/nf-core/rnavar/issues/135
My original PR for adding the UNZIP feature (https://github.com/nf-core/rnavar/pull/116) wasn't working on AWS. I was building the path to the unzipped file using the map operator on the outputted file because the nf-core module was outputting folder that contained the unzipped file, and the other modules required the full path of the actual unzipped file. To avoid this, I switched to using the GUNZIP module, which I saw is the one being used in the nf-core/rnaseq pipeline, and it is now working for both running it on the cluster and on aws.
To run the test I just downloaded the fasta and gtf files from the test.profile, gzipped them, and ran the following command:
nextflow run nschcolnicov/rnavar -r fix_unzip -latest -profile cluster,bi,test --fasta ../ref/genome.fasta.gz --gtf ../ref/genome.gtf.gz --outdir .
This worked OK:
And for testing the pipeline in AWS, I ran almost the same command:
nextflow run ../../main.nf -profile aws,bi,test --fasta ../ref/genome.fasta.gz --gtf ../ref/genome.gtf.gz --outdir .
Also worked OK:
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).