The default qd and fs filters in the nextflow schema are integers, even though the help text (correctly) identifies that these should be floats.
At the moment, the defaults are integers. These integers can end up in the pipeline which will cause the GATK VariantFilter to fail if the input data contains variants that have fractional values for FS or QD.
PR checklist
[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).
The default qd and fs filters in the nextflow schema are integers, even though the help text (correctly) identifies that these should be floats.
At the moment, the defaults are integers. These integers can end up in the pipeline which will cause the GATK VariantFilter to fail if the input data contains variants that have fractional values for FS or QD.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).