Closed praveenraj2018 closed 2 years ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit e612b8f
+| ✅ 147 tests passed |+
!| ❗ 2 tests had warnings |!
@maxulysse - any idea why some of the tests (push) are failing?
No idea, but I noticed this in other pipelines as well, I'm asking on Slack
@maxulysse Now rest all are completed, except one. It remains "waiting.." for a long time, anything wrong!
Oh yes, we need to update the required tests in the settings, let me do that...
Done.
So now, let's ask for the final reviews
Done.
So now, let's ask for the final reviews
Thanks!
Who will do the final reviews? I think we need two approving reviews..
I have had a quick go-through as I am away this weekend, I will continue next week but it looks great in general! All my comments are relatively small.
As a general comment on testing, its great to see the major pipeline modes tested as part of the CI, but if you have time I would go further. There seems to be some execution pathways that aren't covered with tests.
A step towards the first release of the pipeline.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).