nf-core / sarek

Analysis pipeline to detect germline or somatic variants (pre-processing, variant calling and annotation) from WGS / targeted sequencing
https://nf-co.re/sarek
MIT License
407 stars 413 forks source link

Copy-Number Enhancements - Ascat penality #1510

Open seedgeorge opened 6 months ago

seedgeorge commented 6 months ago

Description of feature

Hi there. I think Sarek is in a good place with the current ASCAT implementation, but I'd like to point towards two things that I think would be helpful for the community.

Kind regards, George

EDIT by @maxulysse - created https://github.com/nf-core/sarek/issues/1512

maxulysse commented 6 months ago

The function ascat.aspcf() (found in the ascat module) accepts a parameter penalty which controls the sensitivity of the tool to potential segment breakpoints. The default is 70 which is usually fine, but for individuals using panel/wes data being able to change this value might be helpful - any chance of exposing this as a param?

This seems easy enough, I'm fairly sure we can add that for 3.5.0

I split your initial issue in 2 different feature requests