nf-core / sarek

Analysis pipeline to detect germline or somatic variants (pre-processing, variant calling and annotation) from WGS / targeted sequencing
https://nf-co.re/sarek
MIT License
410 stars 417 forks source link

Community feedback needed: Consider other tools #95

Open maxulysse opened 4 years ago

maxulysse commented 4 years ago

Issue by @MaxUlysse, moved from SciLifeLab#666

davidmasp commented 4 years ago

Would something like somalier be interesting? just saw in twitter that now it can be integrated in MultiQC. I am not sure if there is a conda package though...

maxulysse commented 4 years ago

Nothing yet in Bioconda. What would be your use case with somalier?

davidmasp commented 4 years ago

Maybe not superuseful in terms of new features. I understand it identifies that tumor/ normal come from the same patient. I think it could be useful in some set ups and maybe also somatic calling for cell lines for instance which aren’t exactly a classical use case for a somatic vc pipeline. Indeed idk about the tool much though.

mvelinder commented 3 years ago

I'd throw my support in for DeepVariant integration under --tools

Is that still a priority? It seemed like it was being worked on back in #105

Thanks!

mvelinder commented 3 years ago

ExpansionHunter would also be a great addition under --tools

maxulysse commented 3 years ago

Hi @mvelinder both are tools that we indeed considered. At the time of #105 deepvariant seemed to big to be integrated into sarek. with DSL2, it would make sense to have it within sarek, so we currently have plan to have all the necessary modules made in nf-core/modules and then integrate into sarek.

egenomics commented 3 years ago

Hi,

For clinical environments it would be great to have a depth calculation tool. Mosdepth is a winner, as already suggested.

Another important tool would be a cnv caller. Manta is not a good tool for it, at least for gene panels. An easy and validated solution would be Exomedepth: https://pubmed.ncbi.nlm.nih.gov/32561899/

abhi18av commented 3 years ago

I'd like to suggest addition of DeepTrio which builds upon DeepVariant, aimed at variant calling of trios or duos.

FriederikeHanssen commented 2 years ago

Expansionhunter & HSMetrics have both been suggested by @marchoeppner https://nfcore.slack.com/archives/CGFUX04HZ/p1647518666493429?thread_ts=1647517444.673109&cid=CGFUX04HZ something for 3.1?

gorgitko commented 2 years ago

Hi, deepvariant has been already incorporated, but without deepTrio, right?

FriederikeHanssen commented 2 years ago

yes that is right

gorgitko commented 2 years ago

Would it be possible to include it in TODO (board)? :innocent: Thanks!

tdanhorn commented 2 years ago

I second the inclusion of Picard Tools CollectHsMetrics (for WES/targeted sequencing), and there is CollectWgsMetrics for WGS. Picard is already there, so all that is needed is an option to run it. I find HsMetrics very useful for assessing coverage (e.g. it can tell you if deeper sequencing might solve a coverage problem or not), and while I can run it manually, it would be much nicer to just have it included. In addition to the genome and the BAM, it needs intervals for targets (i.e. the existing --target_bed parameter) and for baits (would need an equivalent parameter for this). These tools also work nicely with MultiQC. Thank you!

praveenraj2018 commented 2 years ago

It would be nice to have more SV callers in Sarek for better characterization, especially for tumor and normal samples. It is always a challenge to figure-out true/significant calls when there are complex rearrangements exist.

I suggest to include:

GRIDSS2 - Comprehensive characterization of SVs (https://genomebiology.biomedcentral.com/articles/10.1186/s13059-021-02423-x)

and then,

LINX - algorithm classifies somatic structural variation in tumors; It does chaining, clustering, and visualizations provide insights into complex rearrangements (https://www.sciencedirect.com/science/article/pii/S2666979X22000325)

It has been demonstrated in several papers recently in oncology:

https://www.nature.com/articles/s41698-021-00155-6 https://www.nature.com/articles/s41591-020-1072-4.pdf?proof=tr https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7545150/ https://www.biorxiv.org/content/10.1101/781013v1 https://www.frontiersin.org/articles/10.3389/fonc.2022.919118/full https://pubmed.ncbi.nlm.nih.gov/35047820/

mvelinder commented 1 year ago

octopus also looked very promising

https://github.com/luntergroup/octopus

https://www.nature.com/articles/s41587-021-00861-3

maxulysse commented 1 year ago

I was sure it was on our list already

maxulysse commented 1 year ago

@lbeltrame (cc @LMannarino @aldosr @rikizad) to add a tool I'd recommend to create a modules in the nf-core/modules repo following this documentation: https://nf-co.re/developers/modules#writing-a-new-module-reference Please don't hesitate to ping me (either here or on Slack if you need any pointers).

lbeltrame commented 1 year ago

Thanks, Maxime. We have experience writing nf-core modules (we have a handful we use internally, ranging from local modifications to entire pipelines), but I'll make sure to ping if need be (tests can be... problematic ;).

I'll file separate issues on nf-core/modules to track this.

maxulysse commented 1 year ago

I look forward to the opportunity to collaborate

nevinwu commented 1 year ago

Hi all, I'm currently working on a lofreq_somatic module to perform somatic variant calling on paired samples with the lofreq caller. Once it is finished, maybe it would be interesting adding it to sarek as another caller. Tumor-only modes of lofreq have already been implemented and are part of nf-core/modules (lofreq_call and lofreq_callparallel).

Lumimar commented 1 year ago

I am wondering whether there might be scope to extend sarek functionality to add:

Many thanks!

maxulysse commented 1 year ago

Consider adding Normalisation for VCFs before annotation

SofiaMAhmed commented 10 months ago

I would like Octopus to be added to Sarek if possible

maxulysse commented 10 months ago

I would like Octopus to be added to Sarek if possible

I considered that a while back, but the installation was not easy, it seems that it's available on bioconda nowadays, so I'll definitively have a look into it: https://bioconda.github.io/recipes/octopus/README.html

Do you know if the tool is still maintained, I don't see much activity on the github repo

eolaniru commented 4 months ago

would be nice to have vardictjava , a sensitive variant caller added to sarek

bounlu commented 4 months ago

Any fusion detection tool such as LINX or FindDNAFusion will be a great addition.

sci-kai commented 2 weeks ago

It would be nice to have delly integrated into sarek.

It is another SV caller, an nf-core module already exists so I think it might be easy to add this as another variant calling option to the pipeline. Since manta is no longer updated, delly is a good addition that get regular updates and improvements. It has a germline and somatic mode.