Closed tbrittoborges closed 2 months ago
Closes #87
Hey, a couple of small things:
dev
branch (rebase
/merge
)max_
prefix to the column name in the samplesheet. I know only the maximum makes sense here, but for consistency with other thresholds I think it makes sense. 1. Make sure there are no conflicts with the `dev` branch (`rebase`/`merge`)
Resolved the merge conflicts on
assets/schema_input.json
anddocs/usage.md
.2. As far as I can tell, scanpy gives you a percentage (0-100) while the new pipeline parameter is a fraction (0-1). I might be wrong, did not test. I would prefer to change the pipeline parameter to a percentage in this case (integer between 0 and 100).
Changed from float to int.
3. Please add a `max_` prefix to the column name in the samplesheet. I know only the maximum makes sense here, but for consistency with other thresholds I think it makes sense.
Added the
max
prefix.
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 456d47e
+| ✅ 218 tests passed |+
!| ❗ 13 tests had warnings |!
This PR adds support to mitochondrial fraction filtering per sample, a widely used quality metric in snRNAseq.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).