Closed grst closed 7 months ago
nf-core lint
overall result: Passed :white_check_mark:Posted for pipeline commit 379f8ad
+| ✅ 175 tests passed |+
#| ❔ 2 tests were ignored |#
Thanks @fmalmeida, I don't see any major issue... Could probably add more/all output files to the snapshot.
Asking for additional review by @sateeshperi who has worked more with nf-test afaik
Cool. I will then first work in prototyping the tests for the other aligners following the same structure, and in the end, based on review and all we can check if we add or remove some files.
😄
Hi @grst , I have added the nf-test run for the main aligners, alevin, star, cellranger and kallisto. Thus, what is required now is to change the github actions to run them instead of pytests and to have a proper review discussion over the testings.
Hi @grst ,
Have addressed your comment and also changed the ci.yml
to use nf-test. I think it is working.
Let's see if someone else reviews it then. If not, I can approve tomorrow.
Close #91
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).