Closed heylf closed 6 months ago
master
branch :x:base
to dev
Hi @heylf,
It looks like this pull-request is has been made against the heylf/scrnaseq master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the heylf/scrnaseq dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit e20e897
+| ✅ 171 tests passed |+
#| ❔ 4 tests were ignored |#
!| ❗ 3 tests had warnings |!
Now that @fmalmeida set-up nf-test, it would be great to add a testcase for cellranger-arc to make sure such issues don't arise again.
Now that @fmalmeida set-up nf-test, it would be great to add a testcase for cellranger-arc to make sure such issues don't arise again.
I agree. I assigned myself to that issue. I will do it latest before the March Hackathon.
@heylf, could you please take another look? I'm afraid something got screwed up by merging in the template update.
@grst yeah saw right now that this PR was still hanging https://github.com/nf-core/modules/pull/4839. If its merged then it should be fine.
@heylf, if you look at the diff, there's now basically no changes left since I merged in the template update.
@grst Yeah its fine to merge
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).