Closed erkutilaslan closed 1 week ago
nf-core pipelines lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 2b75934
+| ✅ 191 tests passed |+
#| ❔ 1 tests were ignored |#
!| ❗ 21 tests had warnings |!
I see that the fq
tool by default exits with an error if linting issues are found. I think that the way of using it in the pipeline should be instead to use the --lint-mode log
ext.args always. That way the errors are logged and the user can read them instead of having the pipeline fail and exit if issues are found in the validation of FASTQ files.
By adding this to the conf/modules.config
:
withName: FQ_LINT {
ext.args = '--lint-mode log'
}
Do you need to update the README.md
Thanks a lot for the comments and suggestions! I have a question regarding the publishDir
.
The conf/modules.config
contains the following:
publishDir = [
path: { "${params.outdir}/${task.process.tokenize(':')[-1].tokenize('_')[0].toLowerCase()}" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
Which creates a publishDir for fq/lint output. Should I still define the publishDir for the module separately as suggested? If so if someone can explain the logic of the above part I would be grateful :)
closing this PR. fq lint is being implemented under PR #67 .
added barebones fq/lint module to the pipeline. looking for feedback to how to implement it.
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).