Closed nservant closed 2 months ago
Hi @nservant, thanks for reporting. You're definietly right, that the protocol
option currently does not seem to have the expected effect. As you also mentioned, usually there should be no strong impact since the miRNA adapters are provided in the fasta file. However, if clipping is needed this might have some impact.
We are also running some additional tests internally to confirm this.
@christopher-mohr , let me know if you have some insight, I would be happy to work on this code if you figure out something else.
as well protocol
is use specifically for mirtrace, independently of the other tools.
Fixed in #364, please give dev
a try 👍🏻
Description of the bug
I'm wondering if the
protocol
option is well interpreted for the adapter trimming.If I use
--protocol illumina
or--protocol qiaseq
, there is no difference in thefastp
command which is always run with ;I do not think that it has a strong impact on the results, because all adapter sequences are available in the
known_adapters.fa
file, but based on the code ;code:
subworkflows/local/utils_nfcore_smrnaseq_pipeline/main.nf
and
conf/modules.config
I would expect the parameter
--adapter_sequence
to be updated according to the${params.three_prime_adapter}
which is itself defined based on the protocol ?Command used and terminal output
Relevant files
No response
System information
nextflow-23.10.1 smrnaseq-2.3.1