Closed nschcolnicov closed 2 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 7d534cd
+| ✅ 214 tests passed |+
#| ❔ 1 tests were ignored |#
!| ❗ 3 tests had warnings |!
I think we can tackle the upstream points in two stages - lets update here already to match what @atrigila mentioned in terms of recommendations (ch_
and val_
) for the points we need for this PR and then have a subsequent PR where we make sure to update it everywhere else necessary to match nf-core guidelines/recommendations more closely 👍🏻 Might come in handy too when we switch the local modules to nf-core/modules
I added some comments to the code that can be addressed in this same PR or in other, if you think that is better.
The test case for this PR could be this issue: #359 which I think your solution addressed. We can add a simple nf-test that checks the presence of
mirdeep2
files when using genome as input.
Ill look at this separately
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).