Closed nschcolnicov closed 2 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit c9c47d4
+| ✅ 214 tests passed |+
#| ❔ 1 tests were ignored |#
!| ❗ 3 tests had warnings |!
For the test profiles using bowtie_index
such as test_umi and test_skipfastp, I observed that the dev
branch is not running the BAM_SORT_STATS_SAMTOOLS subworkflow on all samples.
This issue arises because when the workflow uses the indexing process to generate bowtie_index
, it creates an output channel that contains the bowtie_index
. However, when the bowtie_index
is provided from params, it is handled as a Groovy variable. This variable gets consumed on the first run of the process and is then not available for the remaining samples.
While running test_skipfastp
in both dev
and this branch, I was noted that in dev
, the following processes were missing:
NFCORE_SMRNASEQ:GENOME_QUANT:BAM_SORT_STATS_SAMTOOLS:SAMTOOLS_INDEX (Clone1_N1_mature_hairpin_genome)
NFCORE_SMRNASEQ:GENOME_QUANT:BAM_SORT_STATS_SAMTOOLS:SAMTOOLS_SORT (Clone1_N1_mature_hairpin_genome)
NFCORE_SMRNASEQ:GENOME_QUANT:BAM_SORT_STATS_SAMTOOLS:BAM_STATS_SAMTOOLS:SAMTOOLS_STATS (Clone1_N1_mature_hairpin_genome)
PREPARE_GENOME:UNTAR_BOWTIE_INDEX (bowtie_index.tar.gz)
NFCORE_SMRNASEQ:GENOME_QUANT:BAM_SORT_STATS_SAMTOOLS:BAM_STATS_SAMTOOLS:SAMTOOLS_IDXSTATS (Clone1_N1_mature_hairpin_genome)
NFCORE_SMRNASEQ:GENOME_QUANT:BAM_SORT_STATS_SAMTOOLS:BAM_STATS_SAMTOOLS:SAMTOOLS_FLAGSTAT (Clone1_N1_mature_hairpin_genome)
This issue was also present when running master
using the test_skipfastp
profile.
These issues are the reasons why the tests are failing. However, these are not issues introduced by these changes. Instead, these changes highlight some pre-existing issues. I will proceed to update the tests with this branch that contains the fixes.
test_skipfastp
UNTAR_BOWTIE_INDEX
is not in the versions snapshot anymore because it now runs outside of the workflow in PREPARE_GENOME
.dev
is missing running BAM_SORT_STATS_SAMTOOLS on some samples as explained above.test_mirgenedb
Channel.fromPath
. Previously, it was using Groovy's file()
function, which works with odd paths, but not with Channel.fromPath
.UNTAR_BOWTIE_INDEX
is not in the versions snapshot anymore because it now runs outside of the workflow in PREPARE_GENOME
.md5sum
because they contain the command used to run, and I changed the name of the mature and hairpin FASTA files.test_umi
UNTAR_BOWTIE_INDEX
is not in the versions snapshot anymore because it now runs outside of the workflow in PREPARE_GENOME
.dev
is missing running BAM_SORT_STATS_SAMTOOLS on some samples as explained above.You might also see another failed assertion about "genome.1.ebwt not found." but I already fixed this in my local branch, it had to do with the naming of the folder where the .ebwt file was stored, when I added metadata to the bowtie_index channel, the untar module has a way of processing where it decides on the folder name based on whether if it finds a meta.id value in the input metadata or not.
Addressing: https://github.com/nf-core/smrnaseq/issues/390
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).