Closed jfy133 closed 5 months ago
master
branch :x:base
to dev
Hi @jfy133,
It looks like this pull-request is has been made against the nf-core/taxprofiler master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the nf-core/taxprofiler dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark:Posted for pipeline commit f9aee61
+| ✅ 195 tests passed |+
Super!!! Well done!!! I will test it now and will approve it once the job is completed.
I hope it works :crossed_fingers:
@sofstam I can't see your comment now, but yes I'm a bit concerned that the tests are failing :( need to investigate what that's meaning...
@sofstam I can't see your comment now, but yes I'm a bit concerned that the tests are failing :( need to investigate what that's meaning...
I deleted it, I think Lili has an updated comment now.
@jfy133 Have you tested the new version of Centrifuge-kreport
in standalone mode?
No I didn't... my understanding from the release it wasn't meant to change...
https://github.com/DaehwanKimLab/centrifuge/releases/tag/v1.0.4.1
How does it look in your own test run/data?
OK found the problem, it was a bug in my bioconda recipe (bad docs)... going to go back and update the recipe and the biocontainer and the moduel... :sweat_smile:
@LilyAnderssonLee final check?
Hopefully :crossed_fingers: fixes #422
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).