Closed LilyAnderssonLee closed 5 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 2534c08
+| ✅ 261 tests passed |+
!| ❗ 2 tests had warnings |!
OK I made some changes to make the channel manipulation more 'nextflowy', namely using transpose
to 'duplciate' a channel but each of one of the two having a different short/long types
separately in each
I then modify both database and read channels to have type as a 'meta-meta', to allow them to combine, and then move the type back into the meta after combining
@LilyAnderssonLee please test when you have time to make sure I didn't get something compeltely wrong
@jfy133 I have run the tests for the test
, test_full
, and test_krakenuniq
, and all of them passed. Great job! I think we can merge this PR once all tests pass.
I forgot to check: did you check with an oldstyle samplesheet without the db_type column ? We wanted to make it optional and if so default to short;long right?
Fix the issue https://github.com/nf-core/taxprofiler/issues/226
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).