Closed LilyAnderssonLee closed 7 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit e805e26
+| ✅ 192 tests passed |+
!| ❗ 3 tests had warnings |!
According to the these comments , the failing download-pipeline step will be ignore for now.
According to the these comments , the failing download-pipeline step will be ignore for now.
or you can remove -stub
from the workflow, but then the tests take forever
@maxulysse I'd prefer to leave it as is for now and address it in the next major release.
According to the these comments , the failing download-pipeline step will be ignore for now.
or you can remove
-stub
from the workflow, but then the tests take forever
Remove -stub
but run the test_nothing
profile?
@jfy133 Should I fix it with your suggestion before this merge?
@jfy133 Should I fix it with your suggestion before this merge?
I think it would result in less changes that the current changes (but I can't really follow those changes :grimacing: )
But up to you!
Personally I don't like merging when tests are failing, so either I fix it, or I disable it.
OK I think this would be OK now as Matthias says that there is no way around it until master
is fixed!
Patch release: 1.1.6
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).