Closed jfy133 closed 6 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit c66dc4e
+| ✅ 258 tests passed |+
!| ❗ 2 tests had warnings |!
@nf-core-bot fix linting
I'm just wondering, are there good cases for when a run accession should not be globally unique, but only within a sample?
Tested and it detects if a
run_accession
and asample Id
are not unique.
Do you approve then @sofstam ?
I'm just wondering, are there good cases for when a run accession should not be globally unique, but only within a sample?
Depends on naming schemes basically... My definition of a run was based on ENA run accessions where they were were unique. But @sofstam had an issue where they were not unique, as they were interpreted as a sequencing run accession (so in the table, the same sequencing run was shared across all the samples).
I approve, shall but shall we merge the template first?
Should hopefully close https://github.com/nf-core/taxprofiler/issues/483
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).