nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
234 stars 187 forks source link

Customized Linting mismatch with Schema linting #1968

Open apeltzer opened 1 year ago

apeltzer commented 1 year ago

Description of the bug

I have a customized internal pipeline that uses the nf-core template but uses only portions of it (as introduced with 2.5X release of tools):

My .nf-core.yml (only the relevant parts of it):

repository_type: pipeline
lint:
  nextflow_config:
  - manifest.name
  - manifest.homePage
  - params.input

This results in linting saying config variable is ignored:

image

But nf-core lint says:

image

Which is true - it is neither in the schema nor in nextflow.config. If I remove the above linting exception, it throws a warning that the pipeline is missing --input.

Cross checking by just running nf-core schema lint . says "all fine":

image

My expectation would be that the linting warning should not even be there....

Command used and terminal output

nf-core lint / nf-core schema lint

System information

tools 2.6, linux on centos 7

asp8200 commented 6 months ago

I was able to reproduce the issue.

The error is raised around here. Not sure how it should be handled 🤔

@mirpedrol @mashehu @apeltzer : Perhaps the function check_for_input_mimetype can just return None in that case?