search

nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
238 stars 188 forks source link

Drop Singularity Hub build file from all repositores / Update linting? #252

Closed apeltzer closed 5 years ago

apeltzer commented 5 years ago

As we already dropped Singularity support and only pull Docker images, we don't really need a Singularity recipe in the respective repositories. This should also be updated in the linting, as we currently lint for the presence of the Singularity file.

Afterwards, we could update each repository and remove the Singularity file & remove it from the template as well.

pachiras commented 5 years ago

Have you decided not to support Singularity? May I ask the reason why?

apeltzer commented 5 years ago

Hi! We do support Singularity, but not singularity hub (as the tagging procedure is cumbersome and requires storing multiple Singularity files in each repository for example).

The singularity profile will use the Docker Hub image and pull from there which is supported by Singularity out of the box 👍

matq007 commented 5 years ago

I can have a look at it and make a PR @apeltzer.

apeltzer commented 5 years ago

That would be fab 👍

pachiras commented 5 years ago

Hello, I'm glad to hear that you won't drop Singularity support. I started using Nextflow recently and I am interested in this project too.

ewels commented 5 years ago

Don't worry, we absolutely won't drop Singularity - we love it! Most of the original nf-core users are running Singularity as the primary back end. It's just Singularity Hub that has been difficult.

pachiras commented 5 years ago

Thank you for your comments. I'll give it a try.

drpatelh commented 5 years ago

Implemented in https://github.com/nf-core/tools/pull/261