search

nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
232 stars 187 forks source link

Changelog bot should add reviewers #2735

Open mashehu opened 7 months ago

mashehu commented 7 months ago

Description of feature

Would be great if changelog bot could list the reviewers (and contributors at the end of the changelog entry)

ewels commented 5 months ago

Copying discussion from @vladsavelyev on Slack:

The problem with the changelog automation is that GitHub doesn't have hooks to trigger something when a PR is finally merged into master. In MultiQC, we trigger it when a PR is created, and allow to re-trigger it manually. When a PR is created, the list of reviewers/contributors most of the time is not full. Which means the maintainer would need to always remember to trigger the bot manually in the end, which partly defeats the purpose

An alternative is to use a "push" event and check that the branch is master, but in this case the bot will have to push to master as the branch wouldn't be relevant at this point

mashehu commented 5 months ago

with this https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review the botshould be triggered on review, no need to wait for merge into master.