Download: Seqera container support - Patch 1 - Githubissues

nf-core / tools

Python package with helper tools for the nf-core community.

https://nf-co.re

MIT License

241 stars 189 forks source link

Download: Seqera container support - Patch 1 #3244

Closed MatthiasZepper closed 4 days ago

MatthiasZepper commented 6 days ago

This PR extends the tests so that Seqera Container support is tested for. It also tweaks the symlink function to support the unconventional registry that Seqera Containers uses.

This is a basic patch. It does neither add oras:// support nor does it fix the issue with the container priority resolution (#3179). For modules using Seqera containers, nf-core download will always download both containers, the native Singularity one and convert the Docker container to Singularity as well.

PR checklist

[x] This comment contains a description of changes (with reason)
[x] CHANGELOG.md is updated
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.34%. Comparing base (354311d) to head (32a7e6b). Report is 17 commits behind head on dev.

Files with missing lines	Patch %	Lines
nf_core/pipelines/download.py	80.00%	4 Missing :warning:

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.