search

nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
241 stars 189 forks source link

add `--dir/-d` option to schema commands #3247

Closed mashehu closed 5 days ago

mashehu commented 5 days ago

Fixes #3234 not sure if we want it also in pipelines create

mirpedrol commented 5 days ago

We already have the option for pipelines create, but on the CLI is called --outdir/-o, we could rename it or better, allow both notations. image

mashehu commented 5 days ago

yeah, was actually thinking the same, only problem is that -d is used for description, so I think it is okay, to have that as an exemption, or what do you think, @nschan?

nschan commented 5 days ago

Personally, I think -o for create is reasonable. I understand -d to mean "run inside dir" whereas -o is output.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.30%. Comparing base (b87106d) to head (f49e9cf). Report is 86 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/__main__.py 72.72% 3 Missing :warning:
Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.