Open pmoris opened 21 hours ago
As mentioned in the issue, I also opened a PR against the conda-forge recipe for textual
: https://github.com/conda-forge/textual-feedstock/pull/150
If/when it gets added there, it would not strictly be necessary to add
linkify-it-py
to the nf-core requirements anymore. But for the time being this would fix problems with people installing it through bioconda at least.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.51%. Comparing base (
eb4c237
) to head (3a80996
). Report is 9 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As described in issue: https://github.com/nf-core/tools/issues/3257
Also see PR against the bioconda recipe (as a temporary fix): https://github.com/bioconda/bioconda-recipes/pull/51762
Unless the conda-forge recipe for textual gets fixed, the bioconda recipe fix might get lost when a new version is built against the PyPi version of nf-core. So I propose that we also explicitly specify
linkify
in therequirements.txt
file.Before this is merged, could someone please verify if the version pinning makes sense? As you can see in the bioconda PR, coderabbitai suggested pinning a specific version, but I think it got it the wrong way around.
PR checklist
CHANGELOG.md
is updateddocs
is updated