nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
244 stars 191 forks source link

Remove toList() channel operation from inside onComplete block #3304

Open robsyme opened 3 days ago

robsyme commented 3 days ago

This PR resolves an important bug in the nf-core template, whereby all workflows will hang if the --email parameter is supplied.

The onComplete block will hang if there are any (queue) channel operations inside the block. All values in the onComplete block must be resolved to single values or value channels before the onComplete block starts.

The async channels are not available inside onComplete, so calling the toList() operation will hang forever as the async queue channel will never be completed.

PR checklist

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.80%. Comparing base (1dd8ea0) to head (71410fd).

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.