search

nf-core / tools

Python package with helper tools for the nf-core community.
https://nf-co.re
MIT License
242 stars 191 forks source link

Enable CI tests for other branches than dev #836

Open maxulysse opened 3 years ago

maxulysse commented 3 years ago

Is your feature request related to a problem? Please describe

I'd like to do some tests on another branch dsl2 on which we're working in Sarek. Can't and won't merge it in its current state in dev, but linting is failing all the time if I enable CI in this specific branch.

Describe the solution you'd like

I'd like to have CI enabled on other branches without nf-core lint failing

Describe alternatives you've considered

Having nf-core lint fail and keep my CI tests on, which is what I'm currently doing

Additional context

Same issue for CI on master as discussed on slack

ewels commented 3 years ago

To clarify, you want CI to run for the push event on all branches, not just dev in this code:

https://github.com/nf-core/tools/blob/8c68650409a3f95376dd55c291dae5f9fc346347/nf_core/pipeline-template/%7B%7Bcookiecutter.name_noslash%7D%7D/.github/workflows/ci.yml#L3-L6

(CI already runs on PRs from all branches, but not every pushed commit).

I know we discussed this already but I forget - why can't you use have a PR open and use the CI tests running there? (Even if it's a WIP / draft PR). That's what I usually do in this scenario..