nf-core / viralrecon

Assembly and intrahost/low-frequency variant calling for viral samples
https://nf-co.re/viralrecon
MIT License
118 stars 108 forks source link

Adding "aggregate" and "plot" methods in the freyja subworkflow #400

Closed bsalehe closed 8 months ago

bsalehe commented 11 months ago

Description of feature

Hi,

Thank you for your amazing pipeline. I am currently testing the dev version which contains a wonderful freyja subworkflow for running mixed samples such as wastewater analysis. Please just asking, would it be nicer if you also include the freyja aggregate and freyja plot methods as they are very useful for downstream analysis? In particular aggregate method which tend to aggregate samples for downstream visualisation.

Cheers!

Joon-Klaps commented 8 months ago

Hi,

With the aggregatefunctionality included would it then be based on existing results? I.e. you give an existing directory of results and then add all your samples to it individually or only combine all the input samples?

Joon-Klaps commented 8 months ago

Because if it is the latter, your issue might already be solved when updating the mutliqc version within the pipeline as it supports Freyja but it hasn't been implemented yet in this pipeline.

Joon-Klaps commented 8 months ago

413

Joon-Klaps commented 8 months ago

Closing this, feel free to reopen if you think the visualisation with multiqc is not good enough.