Properly deal with multiqc in the config files before the next release

nf-core / viralrecon

Assembly and intrahost/low-frequency variant calling for viral samples

https://nf-co.re/viralrecon

MIT License

118 stars 108 forks source link

Properly deal with multiqc in the config files before the next release #411

Open maxulysse opened 8 months ago

maxulysse commented 8 months ago

Description of feature

cc @adamrtalbot @svar

adamrtalbot commented 8 months ago

Could we have a little explanation? I don't really know what this refers to.

svarona commented 4 months ago

Hi again! Correct me if I'm wrong @maxulysse, but I think @adamrtalbot, this is related to the problem that viralrecon has two workflows, each of them with its .config file in conf folder. So each time nf-core-tools are updated, TEMPLATE branch will update MULTIQC in the conf/modules.config file instead of in each of the workflow's config files modules_nanopore.config and modules_illumina.config. Isn't it?

Have you been working on this already?

maxulysse commented 4 months ago

Sorry, I missed @adamrtalbot's comment many moons ago. What I meant was since we have 2 workflows, why don't we try to run multiQC just once as an after step in the NFCORE_VIRALRECON workflow from the main main.nf