search

nf-modules-hub / nextflow_hub_process

A template for nextflow-hub process
MIT License
1 stars 1 forks source link

add a issue and PR templates #2

Closed abhi18av closed 4 years ago

abhi18av commented 4 years ago

@sharma-shruti we need to design the PR and Issue templates - here's a starting point https://tommcfarlin.com/github-pr-templates/

And here are some sample templates

https://github.com/samccone/issue-and-pr-templates

https://github.com/echobind/pr-templates/blob/master/oss/PULL_REQUEST_TEMPLATE

https://github.com/stevemao/github-issue-templates/

sharma-shruti commented 4 years ago

This seems like a good idea.

  1. I remember creating my very first issue for doctl. So when I clicked on New issue, it asked whether this issue is a bug or an enhancement request.
  2. We could do something similar. I wonder if the biologists may have some other requirements.
  3. An Issue template can include:
    • A clear and concise description of the problem.
    • Software or application environment info.
  4. I think for creating a PR request, we first need to have an open issue. We can discuss this later.
abhi18av commented 4 years ago

Cool, please lead the way here 🙂

From: Shruti Sharma notifications@github.com Sent: 27 July 2020 15:31 To: nextflow-hub/nextflow_hub_process nextflow_hub_process@noreply.github.com Cc: Abhinav Sharma abhi18av@outlook.com; Assign assign@noreply.github.com Subject: Re: [nextflow-hub/nextflow_hub_process] add a issue and PR templates (#2)

This seems like a good idea.

  1. I remember creating my very first issue for doctl. So when I clicked on New issue, it asked whether this issue is a bug or an enhancement request.

  2. We could do something similar. I wonder if the biologists may have some other requirements.

  3. An Issue template can include:

    • A clear and concise description of the problem.
    • Software or application environment info.

  4. I think for creating a PR request, we first need to have an open issue. We can discuss this later.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnextflow-hub%2Fnextflow_hub_process%2Fissues%2F2%23issuecomment-664253812&data=02%7C01%7C%7C86e3b3012c4c48cff3bf08d832141564%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637314409115174176&sdata=YBS1WTPq2HdlFGa3Lcaoo8rsXfs%2BI9LcySlx1hv%2B9Ww%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADBU2XRY5SISZKUDMIITW23R5VGA7ANCNFSM4PG4VJJQ&data=02%7C01%7C%7C86e3b3012c4c48cff3bf08d832141564%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637314409115174176&sdata=MNfrygBSilrcC7PydDDVaJ8IfgKY60a4V4K2eyZb2Rg%3D&reserved=0.

abhi18av commented 4 years ago

@sharma-shruti , has initiated efforts in the fastqc repo. However, we need to implement and test them here in this repo first.

https://github.com/nextflow-hub/fastqc/pull/2

abhi18av commented 4 years ago

And the PR related work has been initiated https://github.com/nextflow-hub/fastqc/pull/3 as well.

@sharma-shruti , please read the above comments for testing out this feature in this repo first :)

sharma-shruti commented 4 years ago

Oh sorry. I will work on this repo for template creation.

abhi18av commented 4 years ago

@sharma-shruti , try creating a new issue - you'll see your PR at work!

abhi18av commented 4 years ago

The PR template is still WIP

abhi18av commented 4 years ago

Both the PRs have been merged. Thanks for taking out the time for this @sharma-shruti !