nf-osi / NF_data_curator

Data Ingest Shiny App
https://sagebio.shinyapps.io/NF_data_curator/
Apache License 2.0
1 stars 1 forks source link

Update schematic to v23.1.1 which defaults to service token auth #159

Closed anngvu closed 1 year ago

anngvu commented 1 year ago

Please validate at https://sagebio.shinyapps.io/NF_data_curator-staging/

Also resolves https://github.com/nf-osi/NF_data_curator/issues/154

Required: there is ONE more (easy) step. So when testing at Really remove OOB creds from workflow, I noticed that we couldn't generate a manifest with error: 2023-02-02T07:48:28.539538+00:00 shinyapps[5711947]: Warning: Error in eval: JSONDecodeError: Expecting property name enclosed in double quotes: line 2 column 3 (char 4)

However, since testing locally with my own service token works just fine, I figured something wrong was copied and pasted into secrets, so I updated the relevant secret to confirm, which you can see based on the last update date. (However, I am using the token I have for Gray Foundation, so we really need to update with the NF service token we should be using, but I couldn't see it in console.cloud.google.com for nf-service@sagebase.org.) This issue didn't surface previously bc the app has never actually used the service token before -- it's always used the OOB creds first.

So @allaway can update the secret or tell me where to find/access the secret.

allaway commented 1 year ago

Hmm, we had previously used shared credentials from HTAN as there was no clear documentation on how to generate our own (or, I was unaware of such documentation). Do you know where this is documented/how you did it for GF?

allaway commented 1 year ago

IOW: we don't have an NF token, I don't think.

allaway commented 1 year ago

LGTM, thanks for this!!