nf-osi / nf-metadata-dictionary

Versioned releases of the NF metadata dictionary.
https://nf-osi.github.io/nf-metadata-dictionary/
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Patch tests, schematic update with 'typing_extensions' bug workaround, add `bmp` format #421

Closed anngvu closed 2 months ago

anngvu commented 2 months ago

Fix broken tests (#416) and make sure to use latest version of schematic (#422). Add needed term to trigger tests, assess fix.

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://nf-osi.github.io/nf-metadata-dictionary/pr-preview/pr-421/ on branch gh-pages at 2024-04-11 15:11 UTC

github-actions[bot] commented 2 months ago

Test Suite Report

Template Generation

template result link
AnimalIndividualTemplate :smile: template link
BiospecimenTemplate :smile: template link
ClinicalAssayTemplate :smile: template link
EpigeneticsAssayTemplate :smile: template link
FlowCytometryTemplate :smile: template link
GenomicsAssayTemplate :smile: template link
GenomicsAssayTemplateExtended :smile: template link
HumanCohortTemplate :smile: template link
ImagingAssayTemplate :smile: template link
LightScatteringAssayTemplate :smile: template link
MethylationArrayTemplate :smile: template link
MRIAssayTemplate :smile: template link
PharmacokineticsAssayTemplate :smile: template link
PlateBasedReporterAssayTemplate :smile: template link
ProcessedAlignedReadsTemplate :smile: template link
ProcessedExpressionTemplate :smile: template link
ProcessedVariantCallsTemplate :smile: template link
ProteomicsAssayTemplate :smile: template link
ProtocolTemplate :smile: template link
RNASeqTemplate :smile: template link
ScRNASeqTemplate :smile: template link
UpdateMilestoneReport :smile: template link
WESTemplate :smile: template link
WGSTemplate :smile: template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv :x: Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv :x: Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv :x: Conditional validation for attributes is currently not supported
ScRNASeqTemplate_0.csv :x: Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv :smile: Fail because of missing data in required field libraryStrand