search

nf-osi / nf-metadata-dictionary

Versioned releases of the NF metadata dictionary.
https://nf-osi.github.io/nf-metadata-dictionary/
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Try again to add MRI and new diagnoses #457

Closed allaway closed 1 month ago

allaway commented 1 month ago

These changes were already reviewed in #443, but merge conflicts due to new schematic version make it easier to just create a new branch and PR.

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-05-29 17:47 UTC

github-actions[bot] commented 1 month ago

Test Suite Report 24.5.1

Template Generation

template result link
ClinicalAssayTemplate :smile: template link
EpigeneticsAssayTemplate :smile: template link
FlowCytometryTemplate :smile: template link
GenomicsAssayTemplate :smile: template link
GenomicsAssayTemplateExtended :smile: template link
HumanCohortTemplate :smile: template link
ImagingAssayTemplate :smile: template link
LightScatteringAssayTemplate :smile: template link
MethylationArrayTemplate :smile: template link
MRIAssayTemplate :smile: template link
PharmacokineticsAssayTemplate :smile: template link
PlateBasedReporterAssayTemplate :smile: template link
ProcessedAlignedReadsTemplate :smile: template link
ProcessedExpressionTemplate :smile: template link
ProcessedVariantCallsTemplate :smile: template link
ProteomicsAssayTemplate :smile: template link
ProtocolTemplate :smile: template link
RNASeqTemplate :smile: template link
ScRNASeqTemplate :smile: template link
UpdateMilestoneReport :smile: template link
WESTemplate :smile: template link
WGSTemplate :smile: template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv :smile: Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv :smile: Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv :smile: Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv :smile: There should be no issue with this template.
ScRNASeqTemplate_0.csv :smile: Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv :smile: Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv :smile:
GenomicsAssayTemplate_1.csv :smile:
GenomicsAssayTemplate_2.csv :smile:
GenomicsAssayTemplate_control.csv :smile:
ScRNASeqTemplate_0.csv :smile: