change people functions to synapser

nf-osi / nfportalutils

Utilities for NF Portal project and data management

https://nf-osi.github.io/nfportalutils/

MIT License

2 stars 2 forks source link

change people functions to synapser #168

Closed allaway closed 6 months ago

allaway commented 6 months ago

This PR introduces synapser to Imports and refactors the add_people_from_table and .store_rows functions to use synapser. Modified the .check_login function to look for syn object imported by library(synapser).

allaway commented 6 months ago

@anngvu , any ideas on why it would fail to build this package with synapser on mac and windows but work fine on ubuntu?

anngvu commented 6 months ago

@allaway Since I'm mainly Linux, I'm honestly sure what the Mac and Windows issues are -- the logs aren't super helpful -- will need to look more into it.

anngvu commented 6 months ago

@allaway OK, I think this is actually a GH workflow issue.

anngvu commented 6 months ago

So testing locally:

On Sage Mac laptop, building synapser when installing with pak was not an issue.
On borrowed Windows laptop, couldn't build synapser when installing with pak and there was just not enough information to resolve.

So I revised the workflow to use precompiled synapser from Synapse repo when building from source fail for those OS platforms -- this corresponds with the official installation instructions and is how most users would obtain synapser in any case.