Added support for iOS 13 Dark Mode

nfarina / calloutview

A lightweight callout view class for iOS mimicking UICalloutView.

http://nfarina.com/post/78014139253/smcalloutview-for-ios-7

Apache License 2.0

1.2k stars 189 forks source link

Added support for iOS 13 Dark Mode #114

Closed namannik closed 5 years ago

nfarina commented 5 years ago

Hi, thanks for taking a stab at this! I tried it on my device and the default UI in "dark mode" doesn't really match the system very well:

If you can adjust the callout graphics to match the system style more closely then I would be happy to merge.

namannik commented 5 years ago

Thanks for taking a look. I'll get back to this in a few days and submit a new PR.

namannik commented 5 years ago

I've updated the pull request to better match the system style. (It's not exact, but it's pretty close.)

One remaining issue is the border on containerView and arrowView. On containerView, the border is visible behind the arrow. On arrowView, there is no border. Both of these views are now a UIVisualEffectView, and I haven't managed to figure out how to draw the arrow border without affecting its background color.

namannik commented 5 years ago

One more update: I switched to a different approach that doesn't use a UIVisualEffectView. With this update, the border is now complete around the entire callout, including the arrow.

nfarina commented 5 years ago

Looks much better. Thanks so much for doing this!