search

nfarina / homebridge-sonos

Sonos plugin for homebridge: https://github.com/nfarina/homebridge
155 stars 52 forks source link

use current version of sonos #39

Closed mrose17 closed 7 years ago

mrose17 commented 7 years ago

to avoid bug in earlier version of request package that is used by sonos@0.8.0 -- the bug: if network connectivity was lost, then the earlier version of request would generate an uncaught error resulting in homebridge termination!

the only API impact in the use of sonos@0.12.1 is to use Search.prototype.destroy instead of closing the socket directly in index.js

fwboettger commented 7 years ago

@mrose17 - that's great! Have been trying to figure the root cause for these uncaught exceptions approx a year ago, but hadn't been able to complete then and had to drop the topic since then. I'm pretty sure this would be the solution to all those earlier issues and also quite a few other issues raised by others since beginning this year!

@nfarina - this really seems worthwhile to be merged for an updated version of the plugin:-)

nfarina commented 7 years ago

Thanks for the PR!

mrose17 commented 7 years ago

thank you!