nfarina / homebridge-tesla

Tesla plugin for homebridge: https://github.com/nfarina/homebridge
155 stars 37 forks source link

Added Charge and GPS Home options #15

Closed S0urceror closed 5 years ago

S0urceror commented 5 years ago

Hi,

I added the Charge state so that I am able to switch charging on/off at home. Sometimes I wish to start it a bit earlier then scheduled charging time. Plus I am recording my electricity use at home at charge start and end.

Also added an option to determine if the Tesla is within 100m of home. This way we can create an automation when I pull up the drive way. And together with the charge option only count kWh when I'm home.

Regards,

Mario

nfarina commented 5 years ago

Thanks for the PR!

I'm curious about the "home" switch - have you successfully created any automations that are triggered by that switch? I don't believe HomeKit will "poll" the switch state regularly, so I'd be surprised if Siri ever "knew" the car had come home, for instance.

S0urceror commented 5 years ago

Hi Nick,

Yes you are right.

Already discovered this currently works only on a polling basis. Automations as a result only trigger if you manually open the Home app. This is of course not wanted but let’s call this the first step.

I have earlier implemented a ZWave plugin for Homebridge that works immediately. By holding on to the homebridge objects, everytime one of the ZWave listeners receives an event, I inform homebridge of the change. I will implement this pattern, whenever I have time, on your plugin. Then arriving with my car at home this will trigger immediately something in the home without me having to open the app.

Hopefully soon I will implement this second step.

Let you know.

Regards,

Mario

From: Nick Farina notifications@github.com Reply-To: nfarina/homebridge-tesla reply@reply.github.com Date: Tuesday, 28 May 2019 at 07:44 To: nfarina/homebridge-tesla homebridge-tesla@noreply.github.com Cc: Mario Smit mario.smit.nl@gmail.com, Author author@noreply.github.com Subject: Re: [nfarina/homebridge-tesla] Added Charge and GPS Home options (#15)

Thanks for the PR!

I'm curious about the "home" switch - have you successfully created any automations that are triggered by that switch? I don't believe HomeKit will "poll" the switch state regularly, so I'd be surprised if Siri ever "knew" the car had come home, for instance.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nfarina/homebridge-tesla/pull/15?email_source=notifications&email_token=ABGC6KCZCBLEV2I7KTC4V3TPXTBD5A5CNFSM4HMJYSSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLA3DQ#issuecomment-496373134, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGC6KATSY5JYOPFPXYTP7LPXTBD5ANCNFSM4HMJYSSA.

nfarina commented 5 years ago

Hi Mario!

I've reverted the plugin back to a much simpler state - all the various services that were being added were causing Siri to give wacky orders (for example, unlocking the doors caused the trunks to open as well).

I did add a new switch for charging - so you can say "Turn on the Model 3 Charger" for instance and it will begin charging even if it's not scheduled to charge.

If you do implement the "coming home" functionality in a reliable way, I'd love to see it.

Closing this for now!