search

nfarina / homebridge-tesla

Tesla plugin for homebridge: https://github.com/nfarina/homebridge
154 stars 38 forks source link

Sentry Mode Switch Option #74

Closed farhad-a closed 2 years ago

farhad-a commented 3 years ago

Added a configuration option to load Sentry Mode as a switch, instead of a lock. The default is still a lock.

nfarina commented 3 years ago

Looks great! But curious, why have it as a switch? The side benefit to making it a lock is no one can pick up your phone or yell into your HomePod to control the car.

farhad-a commented 3 years ago

Thank you! I realize my use case may not be in the majority and think the lock mechanism is a good fit and should remain the default option. In my case, I don't use Sentry Mode while at home. So when I ask Siri to "lock all the doors," Sentry Mode turns on. Or if I ask "are all the doors are locked?" Siri reports the unlocked Sentry Mode.

farhad-a commented 3 years ago

Does that use-case make sense? Please let me know if there are any issues I could remedy. Or, questions I could help address.

nfarina commented 2 years ago

I've come around on this - I think the switch actually makes more sense. But also like having the option for folks who prefer the lock. Thanks so much for writing this up and sorry it took so long to merge!

farhad-a commented 2 years ago

Thanks for accepting. And thank you so much for all you have done for the community.