search

nfarina / homebridge-tesla

Tesla plugin for homebridge: https://github.com/nfarina/homebridge
154 stars 38 forks source link

Defrost accessory visible even when it should be disabled #84

Closed gianlucad3 closed 2 years ago

gianlucad3 commented 2 years ago

I have "disableDefrost" set to true, yet I see the Defrost accessory exposed. HB version 1.3.8, tesla plugin 3.4.0. Thanks!

raffertyj commented 2 years ago

Can you tell me if you have disableClimate set to true also? Looking at the code it seems both have to be set to true for defrost to be disabled.

this.disableDefrost = (this.disableClimate && config["disableDefrost"])

pretty sure we want to || that instead

raffertyj commented 2 years ago

created PR 86 to fix this issue.

gianlucad3 commented 2 years ago

disableClimate is false for me. Thanks.