nfarina / homebridge-tesla

Tesla plugin for homebridge: https://github.com/nfarina/homebridge
154 stars 38 forks source link

fixed logic for disableDefrost, should have been or'ed #86

Closed raffertyj closed 2 years ago

raffertyj commented 2 years ago

The logic for disableDefrost was (this.disableClimate && config["disableDefrost"]) which I believe was an accident since we kind of double negative with the var names, 'disable...'. We want defrost to be disabled if the climate OR defrost is set to disabled. We shouldn't require both.

nfarina commented 2 years ago

Good catch, thanks!