Wrong key used for PICC and CMAC

nfc-developer / sdm-backend

Backend server for Secure Dynamic Messaging (SDM). Supports decryption of PICCData, SDMENCFileData, and validation of SDMMAC. Compatible with NTAG 424 DNA (both variants). Written in Python 3 Flask. Pull requests welcome.

MIT License

75 stars 39 forks source link

Wrong key used for PICC and CMAC #5

Closed p-gentili closed 4 years ago

p-gentili commented 4 years ago

Hi, I don't know if this is an error on your side or in the documentation I have but it seems that, according to the documentation:

for PICC decryption the SDMMetaReadKey is needed
for CMAC the SDMFileReadKey is needed.

In your implementation you use them in the opposite way instead.

Please let me know what you think about this. Thanks

icedevml commented 4 years ago

Hello, thanks for your suggestion. I will review the datasheet to ensure the naming is correct and get back to you soon.

icedevml commented 4 years ago

@p-gentili Could you look at this patch? Does it address the problem properly?

https://github.com/icedevml/ntag424-backend/pull/6

icedevml commented 4 years ago

@p-gentili Thanks.