search

nfc-tools / libfreefare

A convenience API for NFC cards manipulations on top of libnfc.
Other
395 stars 106 forks source link

[DRAFT] Added examples/mifare-desfire-ev1-change-picc-key #119

Open darconeous opened 4 years ago

darconeous commented 4 years ago

Note: This commit is a work in progress and depends on pull-request #118.

This example demonstrates how to change the PICC key for a DESFire EV1 card, while also aiming to be a generally useful tool for locking/unlocking DESFire credentials.

smortex commented 4 years ago

Ah, this also include changes form #118. Maybe better keep each topic in a dedicated branch, and if you need both changes for working use a custom local branch where you merge both of them :-)

This look okay, but I have no more NFC devices left to try it… I have not been doing NFC for a few years.

I don't remember if I asked if you would be interested in gaining maintainership to libfreefare? I would still be around to help, but as I am mostly alone and not uing this anymore, it really does not makes sense the community rely on me for things to move on :disappointed_relieved:

darconeous commented 4 years ago

It currently depends on those changes. Once #118 is merged, then this one can be considered for merging. I really wish GitHub was better about making those things clear.

I'm happy to help with some maintenance, such as reviewing patches and such. That's about the extent of the amount of responsibility I'm ready to take on at the moment, but I may be willing to take on more later on. (On that topic, what is the state of the whole nfc-tools project? I notice that nfc-tools.org is dead. So is libnfc.org.)

smortex commented 4 years ago

I added you as a collaborator, unless I am wrong, I believe you can approve Pull Requests and merge approved Pull Requests. I guess #118 can be merged quickly, then rebasing this branch on top of master should update it properly and we will be able to sort it out in a timely fashion.

I was aware some websites where broken some times ago, it seems to be worse… Let's try to fix this in nfc-tools/libnfc#558.