Fix compilation issues on Windows

nfc-tools / libnfc

Platform independent Near Field Communication (NFC) library

http://nfc-tools.org

GNU Lesser General Public License v3.0

1.64k stars 436 forks source link

Fix compilation issues on Windows #734

Open ikspress opened 3 weeks ago

ikspress commented 3 weeks ago

I attempted to solve compilation issues on Windows and I have revised my PRs serveral times. Hopefully this will be my last revision, maybe...

The purpose of this PR is as follows.

Fix clang build on mingw
Rewrite resouces files
Fixed pointer type incompatibility warnings
Force dynamic library named libnfc.dll and configure nfc.def when compiling
Add missing MAX_ATR_SIZE
Fix #714

Accoring MSDN and mingw-w64, snprintf() works properly now. In #718, I took mingw-w64-crt's implementation of snprintf(), but it unchanged here.

wizzomafizzo commented 3 days ago

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

ikspress commented 3 days ago

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

Hi. Would you mind tell me what environment you are using? MSYS2, MSVC or others? If you want to run libnfc under MSYS2, there is already a compilation script here. Please refer to readme. If not, please tell me what you are using. If you have any trouble, feel free to tell me what you need.