search

nfc-tools / miLazyCracker

Mifare Classic Plus - Hardnested Attack Implementation for SCL3711 LibNFC USB reader
325 stars 62 forks source link

Add "craptev1-v1.1.tar.xz" and "crapto1-v3.3.tar.xz" to the repository. #13

Closed DavidBerdik closed 5 years ago

DavidBerdik commented 5 years ago

The download links for the craptev1-v1.1.tar.xz and crapto1-v3.3.tar.xz packages in the README are broken, but I was able to find them elsewhere online. To simplify usage a bit, they should be added to the repository.

LudovicRousseau commented 5 years ago

I don't think it is a good idea to to add binary .tar.xz files to a git repository. Why not add the content of the archive instead?

doegox commented 5 years ago

@DavidBerdik Did you read the license of craptev1?

No redistribution. No modifications.

That's why they're not in this repo

DavidBerdik commented 5 years ago

@doegox Ah, okay. My bad. I did not read the license of it because I was not able to find it, but I assumed that redistribution was allowed.

doegox commented 5 years ago

it's written in the header of the source code

DavidBerdik commented 5 years ago

Maybe so, but I never looked at it. It is unfortunate that the original developers chose to make it so restrictive and then stopped sharing it themselves, but I understand the implications of the license.

doegox commented 5 years ago

indeed, weird and unfortunate

DavidBerdik commented 5 years ago

At the very least, could the README be updated with the working download links I have? A hash of the files should also probably be listed for safety.

doegox commented 5 years ago

ok please submit a PR

DavidBerdik commented 5 years ago

Done! - #14