search

nfdi4cat / voc4cat

A SKOS vocabulary for catalysis maintained by NFDI4Cat & friends
https://nfdi4cat.github.io/voc4cat/
Creative Commons Zero v1.0 Universal
10 stars 8 forks source link

Add new concepts heterogeneous catalysis #41

Closed schumannj closed 5 months ago

schumannj commented 5 months ago

I added my first 10 concepts with definitions.

heterogeneous catalysis thermal catalysis heterogeneous catalyst reaction feed reagent active site stability measurement kinetic measurement reaction name reaction type

dalito commented 5 months ago

The failure has nothing to do with your PR. It is caused by a too strict validation rule for GitHub usernames in the IDranges file. It turns out that GitHub usernames can include uppercase (@HendrikBorgelt caused this); they are case-insensitive in comparisons but case preserving. I'll change the regex in another PR.

dalito commented 5 months ago

I have released a fixed version of voc4cat-tool (0.7.9) and updated the workflows here. In order to get the updated workflow file into your fork, you have to rebase your fork. Do you know how to do it? Here is some info.

schumannj commented 5 months ago

Thanks @dalito, I have updated the branch. It didnt seem to have worked as a proper rebase. it this the reason why the workflow was not initiated?

dalito commented 5 months ago

The workflow was successful. Your Excel file was converted to new turtle files that have been auto-commited. Then Excel was removed. You can look at the commit list to see this. The job was this one: https://github.com/nfdi4cat/voc4cat/actions/runs/7754383109/job/21147618851

So it was successful!