nfdi4plants / ARCCommander

Tool to manage your ARCs
MIT License
11 stars 9 forks source link

[BUG] ASSAY PERFORMERS added as STUDY CONTACTS to isa.investigation.xlsx #216

Closed andreaschrader closed 10 months ago

andreaschrader commented 11 months ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Manually enter ASSAY PERFORMERS as registering these did not work in my hands using arc commander via command line.
  2. arc update
  3. Manually added ASSAY PERFORMERS are added to STUDY CONTACTCS
  4. When executing arc update again with and without changes, the ASSAY PERFORMERS are added again to STUDY CONTACTS (in duplicate)
  5. When executing arc update a third time, this does not happen again.

Expected behavior In my opinion, adding ASSAY PERFORMERS to the isa.investiagtion file is important. As they are in many cases not the study contact persons, a seperate section for ASSAY PERFORMERS with the respective assay identifier would be best. Multiple performers could maybe be added as lists seperated with a semicolon in the same column as the respective Study Assay Identifier (or currently "Study Assay File Name")?

Also, adding assay information for isa.assay to isa.study for respective assays registered to a study would be beneficial with respect to contributing persons in case only part of an ARC is published or transferred. For assay performers with respect to arc validation, I do not see the requirement of mail addresses being mandatory.

OS and framework information (please complete the following information):