nfdi4plants / ARCTokenization

Definition of controlled vocabulary tokens and library to tokenize ARC metadata into these tokens
https://nfdi4plants.github.io/ARCTokenization/
MIT License
4 stars 2 forks source link

Terms with long and short annotation should be handled as equal #61

Open HLWeil opened 1 week ago

HLWeil commented 1 week ago
let short = CvTerm.create("DPBO:1000164","plant growth protocol","DPBO")
let long = CvTerm.create("http://purl.org/nfdi4plants/ontology/dpbo/DPBO_1000164","plant growth protocol","DPBO")

short = long

returns false, but should IMO return true.

omaus commented 5 days ago

Don't understand... you want to have the URI directly transformed into the respective ID (on creation) or that .Compare() does that only on comparison? @HLWeil

HLWeil commented 2 days ago

In the example above, I create two ontology term objects that are equal, as they both depict the same ontology term "DPBO:1000164", just in different formats.

But logic is missing which covers this. Therefore there can be validation cases which only work against one of the two formats.

omaus commented 2 days ago

I should use the same logic as in ARCtrl. @omaus

HLWeil commented 2 days ago

https://github.com/nfdi4plants/ARCtrl/blob/68a42b78dac16a0dd01f56ad04cf00cb57de91ac/src/Core/OntologyAnnotation.fs#L52